Skip to content

Add GoogleGenerativeAIInstrumentor #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Dwij1704 merged 10 commits into from
Apr 24, 2025
Merged

Add GoogleGenerativeAIInstrumentor #932

Dwij1704 merged 10 commits into from
Apr 24, 2025

Conversation

@Dwij1704
Copy link
Member

@Dwij1704 Dwij1704 commented Apr 23, 2025

📥 Pull Request

Closes #931
📘 Description
Add GoogleGenerativeAIInstrumentor and new span attribute

  • Introduced GoogleGenerativeAIInstrumentor to the available instrumentors.
  • Added LLM_REQUEST_TOP_K attribute to SpanAttributes for enhanced telemetry.
  • Updated gemini_example notebook to reflect changes in API usage and improved examples.
  • Revised README to update package installation instructions and example usage.

🧪 Testing
Ran a comprehensive example: https://gist.github.com/Dwij1704/bed8cb9ffe1dba16f8de91ad356b5ada

@Dwij1704 Dwij1704 requested review from bboynton97 and tcdent April 23, 2025 18:43
@codecov
Copy link

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.19048% with 415 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...umentation/google_generativeai/attributes/model.py 0.00% 137 Missing ⚠️
...trumentation/google_generativeai/stream_wrapper.py 0.00% 121 Missing ⚠️
...rumentation/google_generativeai/attributes/chat.py 0.00% 62 Missing ⚠️
...nstrumentation/google_generativeai/instrumentor.py 0.00% 48 Missing ⚠️
...mentation/google_generativeai/attributes/common.py 0.00% 29 Missing ⚠️
...ps/instrumentation/google_generativeai/__init__.py 0.00% 14 Missing ⚠️
...ntation/google_generativeai/attributes/__init__.py 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

tcdent
tcdent reviewed Apr 23, 2025
View reviewed changes
@Dwij1704
Refactor attribute handling in Google Generative AI instrumentation a…
24df087 
…nd added new request configuration attributes to SpanAttributes
tcdent
tcdent requested changes Apr 23, 2025
View reviewed changes
@Dwij1704
Refactor chat message attribute assignment to use MessageAttributes c…
9b035bb 
…onstants for improved clarity and consistency
@Dwij1704 Dwij1704 requested a review from tcdent April 23, 2025 19:36
@Dwij1704 Dwij1704 merged commit afce320 into main Apr 24, 2025
7 of 10 checks passed
@Dwij1704 Dwij1704 deleted the google-genai-instrumentation branch April 24, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tcdent tcdent tcdent approved these changes

@bboynton97 bboynton97 Awaiting requested review from bboynton97

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Gemini instrumentation

3 participants

@Dwij1704 @tcdent